Remove unhelpful isCrossOrigin test. #2715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pam retry |
gkatsev
force-pushed
the
remove-unhelpful-isCrossOrigin-test
branch
2 times, most recently
from
f8db397
to
af4d3ad
Compare
This test was checking that an "https:" page could load protocol-relative urls as non-cross origin. However, IE and chrome handled the parsing of the urls differently. In IE, the url was parsed to have a protocol of ':' which we chould then backfill to be 'https:'. But chrome parsed it to have a protocol of 'http:' because our test page was loaded over http. Having this test is causing more issues than is worth having it.
This reverts commit f4e5675.
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: eb32719 (Please note that this is a fully automated comment.) |
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: ca5d28a (Please note that this is a fully automated comment.) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was checking that an "https:" page could load
protocol-relative urls as non-cross origin. However, IE and chrome
handled the parsing of the urls differently. In IE, the url was parsed
to have a protocol of ':' which we chould then backfill to be 'https:'.
But chrome parsed it to have a protocol of 'http:' because our test page
was loaded over http. Having this test is causing more issues than is
worth having it.